Document -max_replication_lag_allowed flag#957
Conversation
|
✔️ Deploy Preview for vitess ready! 🔨 Explore the source changes: f7edebd 🔍 Inspect the deploy log: https://app.netlify.com/sites/vitess/deploys/620d4fdcb3e6c200070822ac 😎 Browse the preview: https://deploy-preview-957--vitess.netlify.app |
|
|
||
| <div class="cmd"> | ||
|
|
||
| While switching traffic ensure that the VReplication lag for the workflow is less than this duration, otherwise |
There was a problem hiding this comment.
it's number of seconds, right? IMO, saying duration here may be confusing as many flags take a golang duration value like "5s" but here it would just be 5.
There was a problem hiding this comment.
It is a duration maxReplicationLagAllowed := subFlags.Duration("max_replication_lag_allowed"
There was a problem hiding this comment.
Ah, OK. So instead it's this that I think is confusing/misleading: https://github.com/vitessio/vitess/blob/6443bb502885dda91af6b5337e7bc682cb2861d9/go/vt/vtctl/vtctl.go#L2299
the "in seconds" part. No?
There was a problem hiding this comment.
Yes, the comment for the flag is incorrect, will fix in my next PR.
mattlord
left a comment
There was a problem hiding this comment.
In addition to updating the flag name to max_replication_lag_allowed, could you please copy these changes to the new 14.0 versions of the pages?
- content/en/docs/14.0/reference/vreplication/flags.md
- content/en/docs/14.0/reference/vreplication/switchtraffic.md
Those pages started as carbon copies of the 13.0 ones, so we can just copy them as-is to the 14.0 directory.
Thank you!
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
c2d5461 to
81819d8
Compare
c52456a to
0957c24
Compare
Signed-off-by: Matt Lord <mattalord@gmail.com>
0957c24 to
f7edebd
Compare
Document new flag implemented in vitessio/vitess#9538
Signed-off-by: Rohit Nayak rohit@planetscale.com
Relevant change here: https://deploy-preview-957--vitess.netlify.app/docs/13.0/reference/vreplication/switchtraffic/#-max_transaction_lag_allowed