Merged
Conversation
✅ Deploy Preview for vitess ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
f216ecf to
ef50034
Compare
Signed-off-by: bddicken <bddicken@gmail.com>
ef50034 to
f130299
Compare
5 tasks
Collaborator
Author
|
@mattlord All the comments you mentioned should be fixed for this PR. lmk what you think. |
mattlord
approved these changes
May 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been going through vitess docs / building / walkthroughs and noticed a few small issues in the docs:
In the mac docs, do not need to explicitly execute
source ../common/env.shbefore./101_initial_cluster.sh../101_initial_cluster.shdoes that within the script!On
Ubuntu 24.04 LTS,sudo apt install etcddoes not work. I tried several things to get it to work, and ultimately settled on installing bothetcd-serverandetcd-client. Perhaps I'm missing something, so please let me know if I'm off here.