Skip to content

update docs after explicitly allowing bind addressed in servenv #1600

Merged
frouioui merged 1 commit intoprodfrom
gen-docs-for-13188
Oct 5, 2023
Merged

update docs after explicitly allowing bind addressed in servenv #1600
frouioui merged 1 commit intoprodfrom
gen-docs-for-13188

Conversation

@frouioui
Copy link
Copy Markdown
Member

@frouioui frouioui commented Sep 25, 2023

vitessio/vitess#13188

Note: this PR also include a small fix to ./tools/sync_cobradocs.sh to sed the modified files in order to make all path anonymous.

@netlify
Copy link
Copy Markdown

netlify bot commented Sep 25, 2023

Deploy Preview for vitess ready!

Name Link
🔨 Latest commit f91265a
🔍 Latest deploy log https://app.netlify.com/sites/vitess/deploys/651dfa29fcfb3600083cd4fa
😎 Deploy Preview https://deploy-preview-1600--vitess.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

--config-file-not-found-handling ConfigFileNotFoundHandling Behavior when a config file is not found. (Options: error, exit, ignore, warn) (default warn)
--config-name string Name of the config file (without extension) to search for. (default "vtconfig")
--config-path strings Paths to search for config files in. (default [/Users/andrew/dev/vitess])
--config-path strings Paths to search for config files in. (default [/Users/florentpoinsard/Code/vitess])
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh shoot this is fine to merge but can you open an issue for us to fix/anonymize this?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done: #1601

@frouioui frouioui force-pushed the gen-docs-for-13188 branch from bbd2cdf to c100bc7 Compare October 4, 2023 18:22
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui force-pushed the gen-docs-for-13188 branch from c100bc7 to f91265a Compare October 4, 2023 23:50
--config-file-not-found-handling ConfigFileNotFoundHandling Behavior when a config file is not found. (Options: error, exit, ignore, warn) (default warn)
--config-name string Name of the config file (without extension) to search for. (default "vtconfig")
--config-path strings Paths to search for config files in. (default [/Users/andrew/dev/vtwebsite/vitessio.website/vitess])
--config-path strings Paths to search for config files in. (default [<WORKDIR>])
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@frouioui frouioui merged commit 34b5c22 into prod Oct 5, 2023
@frouioui frouioui deleted the gen-docs-for-13188 branch October 5, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants