Conversation
✅ Deploy Preview for vitess ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
af3e939 to
96a4540
Compare
Signed-off-by: Max Englander <max@planetscale.com>
96a4540 to
57af025
Compare
6 tasks
rsajwani
approved these changes
Dec 7, 2022
| This differs from the standard mysql, in mysql unqualified tables will fail if the correct database is not set on the connection. | ||
|
|
||
| This feature works only for unique table names provided in the [VSchema](https://vitess.io/docs/concepts/vschema/), and only when no default keyspace is set on the connection. | ||
| This feature works only for unique table names provided in the [VSchema](https://vitess.io/docs/concepts/vschema/), and only when no default keyspace is set on the connection. One exception to the uniqueness rule is [Reference Tables](../../../user-guides/vschema-guide/advanced-vschema/#reference-tables) that share a name with an explicitly specified `source` table. |
Collaborator
There was a problem hiding this comment.
no default keyspace is set on the connection
Do you have a link to 'default keyspace' documentation. Can you u hyperlink it.
Collaborator
Author
There was a problem hiding this comment.
Hey @rsajwani I do not, as far as I can tell this is the only page that use this phrase.
Collaborator
|
cc: @vitessio/query-serving |
Signed-off-by: Max Englander <max@planetscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accompanies vitessio/vitess#11875.
Document improvements to routing for reference tables:
Given:
k1and an sharded keyspacek2.k1.rand reference tablek2.r.k1.ak2.b.And these queries:
SELECT k2.b JOIN k1.rSELECT a JOIN rSELECT b JOIN rINSERT INTO rThe first query will succeed but will issue queries to both
k1andk2, even though the query could be satisifed just by routing tok2.The next three queries will fail with https://github.com/vitessio/vitess/blob/4ff02c0f7af35a520bfc90d32e77fc13810dfdd9/go/vt/vtgate/vindexes/vschema.go#L566
This PR documents new support for optimally joining and globally routing these three queries:
k2.k1.atok1.r.k2.btok2.r.r.