VReplication: Improve Overview Page#1211
Merged
rohit-nayak-ps merged 4 commits intoprodfrom Nov 8, 2022
Merged
Conversation
Signed-off-by: Max Englander <max@planetscale.com>
✅ Deploy Preview for vitess ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Collaborator
Author
Member
|
Do you mind tag teaming on this PR to address all of the refactoring of this page? |
2b04abc to
617d24c
Compare
Signed-off-by: Matt Lord <mattalord@gmail.com>
617d24c to
b8501dc
Compare
Member
rohit-nayak-ps
left a comment
There was a problem hiding this comment.
changes looks good! left some comments.
Signed-off-by: Matt Lord <mattalord@gmail.com>
Member
|
Thanks, @rohit-nayak-ps ! I made adjustments based on your helpful feedback here: d7815a6 |
Signed-off-by: Matt Lord <mattalord@gmail.com>
39 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove reference to legacy sharding workflows.
Fixes: vitessio/vitess#11598.