Conversation
✅ Deploy Preview for vitess ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
mattlord
left a comment
There was a problem hiding this comment.
Had a couple of minor nits that are up to you. Please don't forget to copy these pages to the 15.0 docs now too.
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com>
165631d to
c9eff41
Compare
deepthi
left a comment
There was a problem hiding this comment.
A surreal PR where 152/156 files have the exact same change
LGTM
mattlord
left a comment
There was a problem hiding this comment.
LGTM! Only thing is the broken global-topo link that I mentioned (my bad). Otherwise looks good so I'll approve so that you can merge after correcting that. ❤️
|
|
||
| `vtctld` is a webserver interface to administer a Vitess cluster. It is usually the first Vitess component to be started after a valid global topology service has been created. | ||
| `vtctld` provides web and gRPC interfaces to manage a single Vitess cluster. | ||
| It is usually the first Vitess component to be started after a valid [global topology service](../../user-guides/configuration-basic/global-topo/) has been created. |
There was a problem hiding this comment.
Sorry! This needs one more level: ../../../user-guides/configuration-basic/global-topo/
You likely already know, but if not, you can look at things locally using Hugo:
/docs-repo-root$ hugo server --buildDrafts --buildFuture &
There was a problem hiding this comment.
TIL. Might have helped me write the last blog post with fewer commits LOL
There was a problem hiding this comment.
You likely already know, but if not, you can look at things locally using Hugo:
i do, i just uhh, assumed 😅 and you caught me
There was a problem hiding this comment.
fwiw, you don't need those flags, since none of the docs are explicitly marked as drafts or have future publish dates (let alone any publish date)
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Leaving a TODO for myself to circle back after merging #1054 !