use planner-version instead of planner_version#1047
Closed
Conversation
Signed-off-by: Andres Taylor <andres@planetscale.com>
ajm188
reviewed
Jun 7, 2022
Contributor
ajm188
left a comment
There was a problem hiding this comment.
i have bad news (😅 🙈): all of these should be double-dash–prefixed (e.g. -planner-version => --planner-version, and every other flag in that table in vtgate.md)
3 tasks
✅ Deploy Preview for vitess ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Signed-off-by: Andres Taylor <andres@planetscale.com>
ajm188
approved these changes
Jun 7, 2022
deepthi
reviewed
Jun 8, 2022
| from the two planners, the query will fail and the difference will be printed in VTGate's logs as a warning. | ||
|
|
||
| This tool is enabled by the use of a new planner: `Gen4CompareV3`, to use it, we must start VTGate with the `-planner_version` | ||
| This tool is enabled by the use of a new planner: `Gen4CompareV3`, to use it, we must start VTGate with the `-planner-version` |
Comment on lines
31
to
35
| | -output-mode | string | Output in human-friendly text or json (default "text") | | ||
| | -planner_version | string | Sets the query planner version to use when generating the explain output. Valid values are V3 and Gen4 (default "Gen4") | | ||
| | -planner-version | string | Sets the query planner version to use when generating the explain output. Valid values are V3 and Gen4 (default "Gen4") | | ||
| | -normalize | | Whether to enable vtgate normalization (default false) | | ||
| | -shards | int | Number of shards per keyspace (default 2) | | ||
| | -replication-mode | string | The replication mode to simulate -- must be set to either ROW or STATEMENT (default "ROW") | |
Collaborator
There was a problem hiding this comment.
All of these too.
Btw, the changes to vtgate.md are duplicated in #1046. Two ways to resolve:
- only change the compatibility doc in this PR and let Update flag related syntax in Reference section #1046 handle the rest.
- also change vtexplain.md in this PR and let Update flag related syntax in Reference section #1046 do a merge/rebase.
Member
Collaborator
|
Included in #1046 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andres Taylor andres@planetscale.com