Document new tablet_type defaults for vreplication#1003
Merged
Conversation
Signed-off-by: Matt Lord <mattalord@gmail.com>
3 tasks
1419d47 to
8d47293
Compare
Signed-off-by: Matt Lord <mattalord@gmail.com>
8d47293 to
c647a97
Compare
✅ Deploy Preview for vitess ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for vitess ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for vitess ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for vitess ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
679678e to
d21a414
Compare
Signed-off-by: Matt Lord <mattalord@gmail.com>
d21a414 to
c265a7f
Compare
FancyFane
reviewed
Apr 7, 2022
Collaborator
FancyFane
left a comment
There was a problem hiding this comment.
One question I had for this review, did you want to run your sed statement through these files to turn single dashes into double dashes as you had done in previous pull request?
sed -e ':duit' -r -i '' -e 's/(.*[[:space:]]+[`]*)(-[a-z,A-Z]+[a-z,A-Z,-_`]+)([[:space:]]+.*)/\1-\2\3/g' -e 't duit' <path_to_file>
Member
Author
I decided against it as I'm editing quite a few files and I didn't want to drown out the meaningful changes I'm making here. Thank you for checking though! |
Signed-off-by: Matt Lord <mattalord@gmail.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This documents the changes made in vitessio/vitess#10040