Document VReplication Source Throttling For Copy Table#1002
Merged
Conversation
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
3 tasks
✅ Deploy Preview for vitess ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
740f5b7 to
5aa5c27
Compare
62b4a06 to
2a2d9c7
Compare
FancyFane
reviewed
Apr 5, 2022
Collaborator
FancyFane
left a comment
There was a problem hiding this comment.
Reviewing the changes I only had one question for the technical content.
Signed-off-by: Matt Lord <mattalord@gmail.com>
2a2d9c7 to
5397c1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This documents the work done in vitessio/vitess#9923
I also used this one liner to move all long flags from single dash to double dash (single is deprecated in 14.0) in the files edited in the PR:
That gets most of them and a manual review can be done to ensure everything is good.