Skip to content

ci: randomize unit test execution order.#18700

Closed
arthurschreiber wants to merge 7 commits intomainfrom
arthur/enable-test-shuffling
Closed

ci: randomize unit test execution order.#18700
arthurschreiber wants to merge 7 commits intomainfrom
arthur/enable-test-shuffling

Conversation

@arthurschreiber
Copy link
Copy Markdown
Member

@arthurschreiber arthurschreiber commented Sep 26, 2025

Description

This enables randomization of unit test execution order to help find tests that are incorrectly dependent on other tests being executed first.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

AI Disclosure

@arthurschreiber
Randomize unit test execution order.
fb2b4e0 
Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Sep 26, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Sep 26, 2025
@github-actions github-actions bot added this to the v23.0.0 milestone Sep 26, 2025
@arthurschreiber arthurschreiber added Type: Internal Cleanup Component: Build/CI and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Sep 26, 2025
@arthurschreiber
Reset flags after test has finished.
234b1b7 
Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
@arthurschreiber
Correctly revert global variable changes.
defa33b 
Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 26, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.50%. Comparing base (6b4fa3d) to head (defa33b).
⚠️ Report is 64 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #18700      +/-   ##
==========================================
- Coverage   67.50%   67.50%   -0.01%     
==========================================
  Files        1608     1608              
  Lines      263594   263594              
==========================================
- Hits       177931   177926       -5     
- Misses      85663    85668       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@systay systay modified the milestones: v23.0.0, v24.0.0 Oct 8, 2025
@arthurschreiber arthurschreiber mentioned this pull request Oct 29, 2025
Merged
5 tasks
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 8, 2025

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

  • Push additional commits to the associated branch.
  • Remove the stale label.
  • Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

@github-actions github-actions bot added Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. and removed Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. labels Nov 8, 2025
@arthurschreiber
Merge branch 'main' of https://github.com/vitessio/vitess into arthur…
e353307 
…/enable-test-shuffling

Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
@arthurschreiber
Also shuffle non-flaky tests.
f3eb945 
Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
@arthurschreiber
Fail early on error, and properly clean up the throttler.
8dd39e3 
Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
@arthurschreiber
Use write locks when modifying the histogram.
eb8a42f 
Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 26, 2025

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

  • Push additional commits to the associated branch.
  • Remove the stale label.
  • Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

@github-actions github-actions bot added the Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. label Dec 26, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 2, 2026

This PR was closed because it has been stale for 7 days with no activity.

@github-actions github-actions bot closed this Jan 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frouioui frouioui Awaiting requested review from frouioui frouioui will be requested when the pull request is marked ready for review frouioui is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps will be requested when the pull request is marked ready for review rohit-nayak-ps is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

Component: Build/CI Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. Type: Internal Cleanup

Projects

None yet

Milestone

v24.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@arthurschreiber @systay