Skip to content

[release-20.0] Remove mysql57/percona57 bootstrap images (#16620)#16623

Merged
deepthi merged 1 commit intorelease-20.0from
backport-16620-to-release-20.0
Aug 20, 2024
Merged

[release-20.0] Remove mysql57/percona57 bootstrap images (#16620)#16623
deepthi merged 1 commit intorelease-20.0from
backport-16620-to-release-20.0

Conversation

@vitess-bot
Copy link
Copy Markdown
Contributor

@vitess-bot vitess-bot bot commented Aug 20, 2024

Description

This is a backport of #16620

@vitess-bot
Copy link
Copy Markdown
Contributor Author

vitess-bot bot commented Aug 20, 2024

Hello @frouioui, there are conflicts in this backport.

Please address them in order to merge this Pull Request. You can execute the snippet below to reset your branch and resolve the conflict manually.

Make sure you replace origin by the name of the vitessio/vitess remote

git fetch --all
gh pr checkout 16623 -R vitessio/vitess
git reset --hard origin/release-20.0
git cherry-pick -m 1 5cb66a1797a17c05b447acda5f923c62e5912b27

@vitess-bot vitess-bot bot requested a review from derekperkins August 20, 2024 20:15
@vitess-bot
Copy link
Copy Markdown
Contributor Author

vitess-bot bot commented Aug 20, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot requested review from GuptaManan100 and frouioui August 20, 2024 20:15
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui removed Skip CI Skip CI actions from running Merge Conflict labels Aug 20, 2024
@frouioui frouioui force-pushed the backport-16620-to-release-20.0 branch from d66ed75 to f6a574b Compare August 20, 2024 20:19
@frouioui frouioui marked this pull request as ready for review August 20, 2024 20:19
@github-actions github-actions bot added this to the v20.0.2 milestone Aug 20, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.67%. Comparing base (bc754b9) to head (f6a574b).
Report is 1 commits behind head on release-20.0.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-20.0   #16623      +/-   ##
================================================
+ Coverage         68.65%   68.67%   +0.02%     
================================================
  Files              1541     1541              
  Lines            197890   197890              
================================================
+ Hits             135854   135904      +50     
+ Misses            62036    61986      -50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deepthi deepthi merged commit d503fa4 into release-20.0 Aug 20, 2024
@deepthi deepthi deleted the backport-16620-to-release-20.0 branch August 20, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants