Skip to content

Bugfix: Solve ACL issues with CTEs#16548

Closed
systay wants to merge 2 commits intovitessio:mainfrom
planetscale:fix-cte-acl-issues
Closed

Bugfix: Solve ACL issues with CTEs#16548
systay wants to merge 2 commits intovitessio:mainfrom
planetscale:fix-cte-acl-issues

Conversation

@systay
Copy link
Copy Markdown
Collaborator

@systay systay commented Aug 7, 2024

Description

Related Issue(s)

Solves #16542

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

systay added 2 commits August 7, 2024 07:59
@systay
refactor test to use testify
0fbb87b 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
add semanticCheck proto field
3a998ff 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Aug 7, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Aug 7, 2024
@github-actions github-actions bot added this to the v21.0.0 milestone Aug 7, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.78%. Comparing base (d042d7c) to head (3a998ff).
Report is 31 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #16548      +/-   ##
==========================================
+ Coverage   68.76%   68.78%   +0.02%     
==========================================
  Files        1556     1556              
  Lines      199715   199806      +91     
==========================================
+ Hits       137328   137445     +117     
+ Misses      62387    62361      -26

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GrahamCampbell GrahamCampbell mentioned this pull request Aug 7, 2024
Merged
5 tasks
@GuptaManan100 GuptaManan100 mentioned this pull request Aug 23, 2024
Merged
5 tasks
@GuptaManan100
Copy link
Copy Markdown
Contributor

GuptaManan100 commented Aug 23, 2024

Superseded by #16642

This was referenced Sep 13, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal will be requested when the pull request is marked ready for review harshit-gangal is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord will be requested when the pull request is marked ready for review mattlord is a code owner

@beingnoble03 beingnoble03 Awaiting requested review from beingnoble03 beingnoble03 will be requested when the pull request is marked ready for review beingnoble03 is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps will be requested when the pull request is marked ready for review rohit-nayak-ps is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says

Projects

None yet

Milestone

v21.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@systay @GuptaManan100