Skip to content

Group Concat function support for separator#16237

Merged
systay merged 7 commits intovitessio:mainfrom
planetscale:group-concat-panic
Jun 24, 2024
Merged

Group Concat function support for separator#16237
systay merged 7 commits intovitessio:mainfrom
planetscale:group-concat-panic

Conversation

@GuptaManan100
Copy link
Copy Markdown
Contributor

@GuptaManan100 GuptaManan100 commented Jun 20, 2024 •
edited
Loading

Description

As pointed out in #16238 the query there panics the vtgate which eventually crashes it.
This PR does 2 fixes -

  1. Adds support for separator field in group concat evaluation on the vtgate.
  2. Fixes the error message the user receives on planning failure and prevents crashes.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@GuptaManan100
test: add failing test case
246aef3 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Jun 20, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jun 20, 2024
@github-actions github-actions bot added this to the v21.0.0 milestone Jun 20, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.59%. Comparing base (f118ba2) to head (e603162).
Report is 204 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #16237      +/-   ##
==========================================
+ Coverage   68.40%   68.59%   +0.18%     
==========================================
  Files        1556     1544      -12     
  Lines      195121   197984    +2863     
==========================================
+ Hits       133479   135811    +2332     
- Misses      61642    62173     +531

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuptaManan100
feat: fix group concat with separator evaluation
2cf1bee 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
refactor: fix the error message to prevent vtgate crash
b6570e5 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100 GuptaManan100 changed the title Group Concat function support Group Concat function support for separator Jun 20, 2024
@GuptaManan100 GuptaManan100 added Type: Bug Component: Query Serving and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jun 20, 2024
@GuptaManan100 GuptaManan100 marked this pull request as ready for review June 20, 2024 10:11
@GuptaManan100
test: fix tests
0b0fd08 
Signed-off-by: Manan Gupta <manan@planetscale.com>
harshit-gangal
harshit-gangal reviewed Jun 21, 2024
View reviewed changes
go/test/endtoend/vtgate/vitess_tester/aggregation/aggregation.test
Copy link
Copy Markdown
Member

@harshit-gangal harshit-gangal Jun 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that we want to add vitess-tester tests, but there is a cost of adding new test files. For a single query testing should be not update the existing group_concat test in TestGroupConcatAggregation

Copy link
Copy Markdown
Contributor Author

@GuptaManan100 GuptaManan100 Jun 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use vitess_tester for all new tests, because of how much easier it is. Currently, the workflow is running in 6m 24s seconds, even after adding this test.

Copy link
Copy Markdown
Contributor Author

@GuptaManan100 GuptaManan100 Jun 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather like to move all the older tests to vitess_tester

@harshit-gangal harshit-gangal added the Type: Enhancement Logical improvement (somewhere between a bug and feature) label Jun 21, 2024
@GuptaManan100
feat: move checking of empty separator on plan time
1d9c21a 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100 GuptaManan100 requested a review from deepthi as a code owner June 24, 2024 05:36
harshit-gangal
harshit-gangal reviewed Jun 24, 2024
View reviewed changes
harshit-gangal
harshit-gangal reviewed Jun 24, 2024
View reviewed changes
@GuptaManan100
cleanup: remove report.xml
b0a75ea 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
feat: add a constant to store the group concat default separator
e603162 
Signed-off-by: Manan Gupta <manan@planetscale.com>
harshit-gangal
harshit-gangal approved these changes Jun 24, 2024
View reviewed changes
@systay systay merged commit 465ffcf into vitessio:main Jun 24, 2024
@systay systay deleted the group-concat-panic branch June 24, 2024 08:21
This was referenced Jun 24, 2024
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@systay systay systay approved these changes

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

@arthurschreiber arthurschreiber Awaiting requested review from arthurschreiber arthurschreiber is a code owner

@deepthi deepthi Awaiting requested review from deepthi

Assignees

No one assigned

Labels

Component: Query Serving Type: Bug Type: Enhancement Logical improvement (somewhere between a bug and feature)

Projects

None yet

Milestone

v21.0.0

Development

Successfully merging this pull request may close these issues.

Bug Report: Group_concat with separator crashes vtgate during planning

3 participants

@GuptaManan100 @systay @harshit-gangal