Skip to content

Release of v17.0.4#14408

Merged
harshit-gangal merged 6 commits intovitessio:release-17.0from
planetscale:release-17.0-create_release-1
Nov 13, 2023
Merged

Release of v17.0.4#14408
harshit-gangal merged 6 commits intovitessio:release-17.0from
planetscale:release-17.0-create_release-1

Conversation

@mattlord
Copy link
Copy Markdown
Member

@mattlord mattlord commented Oct 31, 2023

Includes the release notes and release commit for the v17.0.4 release. Once this PR is merged, we will be able to tag v17.0.4 on the merge commit.

@mattlord
Release notes for 17.0.4
195372c 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord
Release commit for 17.0.4
bfa9f8f 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord mattlord added Component: General Changes throughout the code base Do Not Merge Type: Release labels Oct 31, 2023
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Oct 31, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Oct 31, 2023
@github-actions github-actions bot added this to the v17.0.4 milestone Oct 31, 2023
@mattlord
Updating release notes
f3e913c 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord mattlord removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Oct 31, 2023
This was referenced Oct 31, 2023
Closed
Closed
@harshit-gangal
Merge remote-tracking branch 'upstream/release-17.0' into release-17.…
8234ae1 
…0-create_release-1

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
added readme with release note
090e42f 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
updated changelog
9216691 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal merged commit 9a3d0f4 into vitessio:release-17.0 Nov 13, 2023
@harshit-gangal harshit-gangal deleted the release-17.0-create_release-1 branch November 13, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@systay systay systay approved these changes

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@deepthi deepthi Awaiting requested review from deepthi

@ajm188 ajm188 Awaiting requested review from ajm188

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach shlomi-noach is a code owner

@derekperkins derekperkins Awaiting requested review from derekperkins derekperkins is a code owner

@dkhenry dkhenry Awaiting requested review from dkhenry

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

Assignees

No one assigned

Labels

Component: General Changes throughout the code base Type: Release

Projects

None yet

Milestone

v17.0.4

Development

Successfully merging this pull request may close these issues.

3 participants

@mattlord @systay @harshit-gangal