Skip to content

INSERTs having Cross shard foreign keys support#13859

Closed
GuptaManan100 wants to merge 3 commits intovitessio:mainfrom
planetscale:fk-verify-planning
Closed

INSERTs having Cross shard foreign keys support#13859
GuptaManan100 wants to merge 3 commits intovitessio:mainfrom
planetscale:fk-verify-planning

Conversation

@GuptaManan100
Copy link
Copy Markdown
Contributor

@GuptaManan100 GuptaManan100 commented Aug 26, 2023 •
edited by harshit-gangal
Loading

Description

This PR adds support for planning DML queries that require a foreign key value to exist on the parent table.

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI

@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Aug 26, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Aug 26, 2023
@github-actions github-actions bot added this to the v18.0.0 milestone Aug 26, 2023
@GuptaManan100 GuptaManan100 mentioned this pull request Aug 29, 2023
Merged
4 tasks
@harshit-gangal harshit-gangal added Type: Feature Component: Query Serving and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Aug 30, 2023
harshit-gangal
harshit-gangal reviewed Aug 30, 2023
View reviewed changes
@GuptaManan100 GuptaManan100 mentioned this pull request Aug 31, 2023
Merged
2 tasks
@GuptaManan100
refactor: refactor insert planning to have forieng key checks in the end
499bdab 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
feat: add preliminary fk verify planning for inserts
02e1a2b 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
feat: fix bug in insert planning
81d66df 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100 GuptaManan100 changed the title Fk verify planning Fk INSERT verify planning Aug 31, 2023
@GuptaManan100 GuptaManan100 changed the title Fk INSERT verify planning INSERTs having Cross shard foreign keys support Sep 27, 2023
@GuptaManan100
Copy link
Copy Markdown
Contributor Author

GuptaManan100 commented Sep 27, 2023

Closing since this work is deferred for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harshit-gangal harshit-gangal harshit-gangal left review comments

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach

@systay systay Awaiting requested review from systay systay will be requested when the pull request is marked ready for review systay is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui will be requested when the pull request is marked ready for review frouioui is a code owner

@arthurschreiber arthurschreiber Awaiting requested review from arthurschreiber arthurschreiber will be requested when the pull request is marked ready for review arthurschreiber is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

Component: Query Serving Type: Feature

Projects

None yet

Milestone

v18.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@GuptaManan100 @harshit-gangal