Skip to content

[release-16.0] Throttler: Store Config in Global Keyspace Topo Record (#12520)#12576

Merged
deepthi merged 22 commits intorelease-16.0from
backport-12520-to-release-16.0
Mar 9, 2023
Merged

[release-16.0] Throttler: Store Config in Global Keyspace Topo Record (#12520)#12576
deepthi merged 22 commits intorelease-16.0from
backport-12520-to-release-16.0

Conversation

@vitess-bot
Copy link
Copy Markdown
Contributor

@vitess-bot vitess-bot bot commented Mar 8, 2023

Description

This is a backport of #12520.

mattlord and others added 22 commits February 28, 2023 19:40
@mattlord
Store throttler config in global Keyspace record
9523c1f 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord
Fix unit test after ThrottlerConfig in Keyspace
aafff30 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord
Apply changes lost in cherry picks
c69ebda 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord
Always wait for a status before the final check.
21afcda 
We should not ever make an assumption about how quickly
an operation will take.

Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord
Propagate PartialResult and other errs back to client
716b917 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@shlomi-noach
Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go
8c53086 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go
4e6a5db 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go
a602961 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go
e9a5d9c 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go
87c1695 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go
6db79f9 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go
178afbf 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go
3829caa 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go
2382d7d 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go
c37138c 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go
1522579 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go
d947f2d 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go
4429ad0 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go
7566fba 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Update go/test/endtoend/onlineddl/vtctlutil.go
dda3552 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Update go/test/endtoend/onlineddl/vtgate_util.go
24635d3 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
fix grammar
956932c 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@vitess-bot vitess-bot bot added the Backport This is a backport label Mar 8, 2023
@vitess-bot vitess-bot bot added the Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) label Mar 8, 2023
@vitess-bot vitess-bot bot requested a review from notfelineit as a code owner March 8, 2023 19:16
@vitess-bot vitess-bot bot added the Type: Bug label Mar 8, 2023
@vitess-bot vitess-bot bot requested a review from rsajwani as a code owner March 8, 2023 19:16
@vitess-bot
Copy link
Copy Markdown
Contributor Author

vitess-bot bot commented Mar 8, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Mar 8, 2023
@mattlord mattlord removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Mar 8, 2023
@deepthi
Copy link
Copy Markdown
Collaborator

deepthi commented Mar 9, 2023

After discussing with @mattlord we decided we do need to backport this. Merging.

@deepthi deepthi merged commit 6e1f08a into release-16.0 Mar 9, 2023
@deepthi deepthi deleted the backport-12520-to-release-16.0 branch March 9, 2023 00:03
@mattlord mattlord mentioned this pull request Apr 20, 2023
Closed
@hmaurer hmaurer mentioned this pull request Mar 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattlord mattlord mattlord approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach shlomi-noach is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@ajm188 ajm188 Awaiting requested review from ajm188

@notfelineit notfelineit Awaiting requested review from notfelineit

@rsajwani rsajwani Awaiting requested review from rsajwani rsajwani is a code owner

+1 more reviewer

@deepthi deepthi deepthi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Backport This is a backport Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) Type: Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@deepthi @mattlord @shlomi-noach