Backport: VDiff2: Support Resuming VDiffs#10589
Merged
mattlord merged 2 commits intovitessio:release-14.0from Jun 27, 2022
Merged
Backport: VDiff2: Support Resuming VDiffs#10589mattlord merged 2 commits intovitessio:release-14.0from
mattlord merged 2 commits intovitessio:release-14.0from
Conversation
Signed-off-by: Matt Lord <mattalord@gmail.com>
And fix a number of bugs discovered related to incorrect VDiff summary handling and other more minor things. Signed-off-by: Matt Lord <mattalord@gmail.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a backport of #10497. While the primary intention of that work was to add a new feature — namely
Resume— in the process of implementing that it became clear that the existing VDiff2 work in 14.0 could easily produce incorrect results and was not easy to validate or debug. There were also a number of other smaller/minor bugs that were fixed in that work. All of this made it very challenging for early adopters to try it out, get value, and provide meaningful feedback (which was the entire reason to get the experimental version into 14.0 in the first place). Because of this, combined with the fact that VDiff2 is experimental and has isolated code, we are backporting this work for 14.0 GA (normally new feature work would only go into main).Related Issue(s)
Checklist