Skip to content

[14.0] fix: scalar aggregation engine primitive#10553

Merged
harshit-gangal merged 1 commit intovitessio:release-14.0from
planetscale:bp-10465
Jun 21, 2022
Merged

[14.0] fix: scalar aggregation engine primitive#10553
harshit-gangal merged 1 commit intovitessio:release-14.0from
planetscale:bp-10465

Conversation

@harshit-gangal
Copy link
Copy Markdown
Member

@harshit-gangal harshit-gangal commented Jun 21, 2022

Description

Backport of PR #10465

This PR fixes two bugs in scalar aggregation engine primitive

  1. Scalar aggregation was returning wrong output for empty row on count aggregation
  2. Scalar aggregation in streaming mode was not handling empty row and also final convert logic.

This was caused when we moved from using AggregateSum over AggregateCount as opcode for count(*). As the actual operation at the engine primitive level was sum of count, this caused a negative effect of returning NULL for empty row instead of 0.

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@harshit-gangal @frouioui
fix: scalar aggregation engine primitive (vitessio#10465)
a3eff9f 
* test: added failing e2e test

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* fix: handle empty row for scalar aggregation and also olap engine for scalar aggregation

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* test: update plan test output

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* test: e2e test for empty rows in non-scalar aggregates

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 21, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive.
  • If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

@harshit-gangal harshit-gangal merged commit 95bd307 into vitessio:release-14.0 Jun 21, 2022
@harshit-gangal harshit-gangal deleted the bp-10465 branch June 21, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frouioui frouioui frouioui approved these changes

@systay systay Awaiting requested review from systay systay is a code owner

Assignees

No one assigned

Labels

Backport This is a backport Component: Query Serving Type: Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@harshit-gangal @frouioui