Skip to content

[14.0] Rework how the release notes labels are handled by the CI #10528

Merged
deepthi merged 1 commit intovitessio:release-14.0from
planetscale:bp-10508-on-14
Jun 17, 2022
Merged

[14.0] Rework how the release notes labels are handled by the CI #10528
deepthi merged 1 commit intovitessio:release-14.0from
planetscale:bp-10508-on-14

Conversation

@frouioui
Copy link
Copy Markdown
Member

@frouioui frouioui commented Jun 16, 2022

Description

This is a backport of #10508.

Related Issue(s)

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

@frouioui
Rework how the release notes labels are handled by the CI (vitessio…
557f823 
…#10508)

* addition of the release_notes_label workflow

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* addition of a helper step in the release_notes_label to guide users

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* addition of a set of rules for release_notes_labels's pull_request target

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* remove the previous workflow that used to check the release notes labels

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Change the review check list and enforce the use of type/component labels

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Fixed syntax in check release notes label workflow

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui requested a review from deepthi June 16, 2022 17:27
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 16, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has the correct release notes label. release notes none should only be used for PRs that are so trivial that they need not be included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive.
  • If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

@deepthi deepthi merged commit 43236ee into vitessio:release-14.0 Jun 17, 2022
@deepthi deepthi deleted the bp-10508-on-14 branch June 17, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@deepthi deepthi deepthi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Backport This is a backport Component: Build/CI Type: CI/Build Type: Release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@frouioui @deepthi