Skip to content

[14.0] Take into account github.ref when doing upgrade-downgrade tests#10522

Merged
deepthi merged 2 commits intovitessio:release-14.0from
planetscale:bp-10504-on-14
Jun 24, 2022
Merged

[14.0] Take into account github.ref when doing upgrade-downgrade tests#10522
deepthi merged 2 commits intovitessio:release-14.0from
planetscale:bp-10504-on-14

Conversation

@frouioui
Copy link
Copy Markdown
Member

@frouioui frouioui commented Jun 16, 2022

Description

This is a backport of #10504 on release-14.0.

Related Issue(s)

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

@frouioui
Take into account github.ref when doing upgrade-downgrade tests (vi…
2594080 
…tessio#10504)

* Take into account the github.ref variable when doing upgrade-downgrade tests

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Changed upgrade-downgrade workflows' syntax to use 'previous' instead of 'latest'

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Fixed syntax error in backup upgrade downgrade workflow

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui requested a review from deepthi June 16, 2022 16:47
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 16, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has the correct release notes label. release notes none should only be used for PRs that are so trivial that they need not be included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive.
  • If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

@frouioui
Fixed static_checks_etc workflow
17252f4 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
deepthi
deepthi approved these changes Jun 17, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving provisionally, see my comment

@frouioui frouioui mentioned this pull request Jun 22, 2022
Closed
43 tasks
@deepthi deepthi merged commit 8453203 into vitessio:release-14.0 Jun 24, 2022
@deepthi deepthi deleted the bp-10504-on-14 branch June 24, 2022 00:43
@deepthi
Copy link
Copy Markdown
Collaborator

deepthi commented Jun 24, 2022

Let's create an issue to track the upgrade/downgrade test failures. Most of the failures are hangs during vttablet startup / vtgate shutdown, so I'm suspecting a problem with the test framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@deepthi deepthi deepthi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Backport This is a backport Component: Build/CI Type: CI/Build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@frouioui @deepthi