Fix upgrade-downgrade build on release-13.0#10503
Merged
deepthi merged 2 commits intovitessio:release-13.0from Jun 17, 2022
Merged
Fix upgrade-downgrade build on release-13.0#10503deepthi merged 2 commits intovitessio:release-13.0from
release-13.0#10503deepthi merged 2 commits intovitessio:release-13.0from
Conversation
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
3 tasks
deepthi
approved these changes
Jun 15, 2022
Collaborator
|
Unfortunately most of the upgrade/downgrade tests are failing on this PR. |
3 tasks
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Collaborator
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request changes the Go version used in the upgrade downgrade tests. It was set to
go1.17.11, with this change it will usego1.18.3which is compatible with any release of Vitess.While fixing this problem, I have realized that upgrade downgrade tests on
v13are testing the current commit and the latest version of vitess, which is in this case:release-14.0; instead it should use the "previous" release:release-12.0. I will open a follow-up issue.Related Issue(s)
Checklist