Skip to content

deprecation of CreateKeyspace flags#10488

Merged
deepthi merged 2 commits intovitessio:release-14.0from
planetscale:ds-deprecate-v2-sharding
Jun 10, 2022
Merged

deprecation of CreateKeyspace flags#10488
deepthi merged 2 commits intovitessio:release-14.0from
planetscale:ds-deprecate-v2-sharding

Conversation

@deepthi
Copy link
Copy Markdown
Collaborator

@deepthi deepthi commented Jun 9, 2022

Description

Mark sharding-column-name and sharding-column-type for CreateKeyspace command as deprecated. They will be removed in v15.

Related Issue(s)

#10378

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@deepthi
Copy link
Copy Markdown
Collaborator Author

deepthi commented Jun 9, 2022

Technically we should not be deprecating after RC, but this functionality is almost certainly used by nobody at this point.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 9, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has the correct release notes label. release notes none should only be used for PRs that are so trivial that they need not be included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive.
  • If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

deepthi added 2 commits June 9, 2022 17:50
Signed-off-by: deepthi <deepthi@planetscale.com>
…reateKeyspace command as deprecated

Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi deepthi merged commit 5259ed6 into vitessio:release-14.0 Jun 10, 2022
@deepthi deepthi deleted the ds-deprecate-v2-sharding branch June 10, 2022 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants