deprecation of CreateKeyspace flags#10488
Merged
deepthi merged 2 commits intovitessio:release-14.0from Jun 10, 2022
Merged
Conversation
Collaborator
Author
|
Technically we should not be deprecating after RC, but this functionality is almost certainly used by nobody at this point. |
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
Signed-off-by: deepthi <deepthi@planetscale.com>
…reateKeyspace command as deprecated Signed-off-by: deepthi <deepthi@planetscale.com>
8adac55 to
038af4a
Compare
ajm188
approved these changes
Jun 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Mark sharding-column-name and sharding-column-type for CreateKeyspace command as deprecated. They will be removed in v15.
Related Issue(s)
#10378
Checklist
Deployment Notes