Skip to content

docs: add query serving features to the release notes#10475

Merged
deepthi merged 3 commits intovitessio:mainfrom
planetscale:release-notes-14-main
Jun 20, 2022
Merged

docs: add query serving features to the release notes#10475
deepthi merged 3 commits intovitessio:mainfrom
planetscale:release-notes-14-main

Conversation

@systay
Copy link
Copy Markdown
Collaborator

@systay systay commented Jun 8, 2022

Description

This is a forward port of #10468

@systay @rohit-nayak-ps
docs: added to the release notes (vitessio#10468)
0f2a59e 
* docs: added to the release notes

Signed-off-by: Andres Taylor <andres@planetscale.com>

* Add name to static check workflow

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

Co-authored-by: Rohit Nayak <rohit@planetscale.com>
@systay systay requested review from frouioui and rohit-nayak-ps June 8, 2022 15:30
@systay systay added Forwardport and removed Backport This is a backport labels Jun 8, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 8, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has the correct release notes label. release notes none should only be used for PRs that are so trivial that they need not be included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive.
  • If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

deepthi
deepthi reviewed Jun 8, 2022
View reviewed changes
@systay
docs: add blurb about gen4 being the new planner
728ac93 
Signed-off-by: Andres Taylor <andres@planetscale.com>
deepthi
deepthi reviewed Jun 13, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the gen4 changes need to be back ported to release-14.0

@deepthi
Copy link
Copy Markdown
Collaborator

deepthi commented Jun 14, 2022

The Gen4 related changes will need to be back ported to release-14.0 prior to GA.

@systay
docs: release notes
f56dc1c 
Signed-off-by: Andres Taylor <andres@planetscale.com>
frouioui
frouioui approved these changes Jun 20, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! We will need to port this to release-14.0 too, I see the original PR has less content than this one.

@systay systay mentioned this pull request Jun 20, 2022
Merged
@deepthi deepthi merged commit bc2f459 into vitessio:main Jun 20, 2022
@deepthi deepthi deleted the release-notes-14-main branch June 20, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frouioui frouioui frouioui approved these changes

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps

+1 more reviewer

@deepthi deepthi deepthi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Component: Build/CI Forwardport Type: CI/Build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@systay @deepthi @frouioui