Skip to content

Bug Report: demoted lag throttler continues to probe the replicas it used to know as PRIMARY #13923

@shlomi-noach

Description

@shlomi-noach

Overview of the Issue

On a PRIMARY tablet, the lag throttler collects the identities of replicas (or otherwise probe-worthy tablets) every 10 seconds, and routinely queries those tablets.

When demoted to REPLICA, e.g. on a PlannedReparentShard, the throttler no longer collects identities of replicas. But there's also no mechanism to remove its pre-existing history of replicas. The demoted throttler therefore continues probing its replicas.

Reproduction Steps

Run PRIMARY and REPLICA, enable the lag throttler. run PlannetReparentShard, observe that the demoted tablet still hits CheckThrottler on the new PRIMARY.

Binary Version

v17, v16

Operating System and Environment details

-

Log Fragments

No response

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions