Bug Report: Vitess lite builds broken -- not able to build VTAdmin #13532
Description
Overview of the Issue
In #13262 we started building vtadmin binaries as part of make build and distributing them along with the other binaries like vtgate and vttablet.
This change impacted the Vitess lite docker image builds as well and they started failing shortly after that PR was merged: https://hub.docker.com/r/vitess/lite/tags
Recent builds and the failures can be seen here: https://hub.docker.com/repository/registry-1.docker.io/vitess/lite/builds
Failure:
2023-07-18T12:17:46Z > [builder 3/3] RUN make install PREFIX=/vt/install:
2023-07-18T12:17:46Z #16 573.5
2023-07-18T12:17:46Z #16 573.5 Configuring Node.js 18.16.0
2023-07-18T12:17:46Z #16 573.5
2023-07-18T12:17:46Z #16 573.8 v18.16.0 is already installed.
2023-07-18T12:17:46Z #16 574.7 nvm is not compatible with the "PREFIX" environment variable: currently set to "/vt/install"
2023-07-18T12:17:46Z #16 574.7 Run `unset PREFIX` to unset it.
2023-07-18T12:17:46Z #16 574.8 Creating default alias: default -> 18.16.0 (-> v18.16.0 *)
2023-07-18T12:17:46Z #16 574.8 ./web/vtadmin/build.sh: line 49: npm: command not found
2023-07-18T12:17:46Z #16 574.8 ./web/vtadmin/build.sh: line 51: npm: command not found
2023-07-18T12:17:46Z #16 574.8 make: *** [Makefile:85: build] Error 127
Looks like we need to add npm here:
vitess/docker/lite/install_dependencies.sh
Lines 41 to 62 in 888df92
Reproduction Steps
N/A
Binary Version
N/AOperating System and Environment details
N/ALog Fragments
N/A