Skip to content

NickAkhmetov/Convert styles package to TypeScript#2400

Merged
NickAkhmetov merged 4 commits intomainfrom
nickakhmetov/vitessce-styles-ts
Feb 3, 2026
Merged

NickAkhmetov/Convert styles package to TypeScript#2400
NickAkhmetov merged 4 commits intomainfrom
nickakhmetov/vitessce-styles-ts

Conversation

@NickAkhmetov
Copy link
Copy Markdown
Collaborator

@NickAkhmetov NickAkhmetov commented Jan 29, 2026 •
edited
Loading

Fixes #2399

Background

Change List

  • Convert style package to TypeScript.

Checklist

  • Have tested PR with one or more demo configurations
  • Documentation added, updated, or not applicable

Note: I removed some non-production code that was reliant on process.env.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 30, 2026

Size Change: -11.2 MB (-60.31%) 🏆

Total Size: 7.35 MB

Filename Size Change
./packages/main/prod/dist/higlass-DNQIME-h.js 0 B -3.57 MB (removed) 🏆
./packages/main/prod/dist/index-********.js 145 kB -11.2 MB (-98.71%) 🏆
./packages/main/prod/dist/higlass-********.js 3.57 MB +3.57 MB (new file) 🆕
ℹ️ View Unchanged
Filename Size
./packages/main/prod/dist/blosc-********.js 612 kB
./packages/main/prod/dist/chunk-INHXZS53-********.js 558 B
./packages/main/prod/dist/deflate-********.js 208 B
./packages/main/prod/dist/index.min.js 1.38 kB
./packages/main/prod/dist/jpeg-********.js 15.6 kB
./packages/main/prod/dist/lerc-********.js 89.3 kB
./packages/main/prod/dist/lz4-********.js 43.9 kB
./packages/main/prod/dist/lzw-********.js 2.07 kB
./packages/main/prod/dist/OrbitControls-********.js 229 kB
./packages/main/prod/dist/packbits-********.js 541 B
./packages/main/prod/dist/pako.esm-********.js 37.1 kB
./packages/main/prod/dist/raw-********.js 133 B
./packages/main/prod/dist/ReactNeuroglancer-********.js 1.67 MB
./packages/main/prod/dist/troika-three-text.esm-********.js 179 kB
./packages/main/prod/dist/webimage-********.js 801 B
./packages/main/prod/dist/zstd-********.js 754 kB

compressed-size-action

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 30, 2026

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 13.25% 9155 / 69083
🔵 Statements 13.25% 9155 / 69083
🔵 Functions 48.53% 529 / 1090
🔵 Branches 67.27% 1396 / 2075
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/styles/src/Popper.tsx 0% 100% 100% 0% 7-249
packages/styles/src/ScopedGlobalStyles.tsx 0% 0% 0% 0% 1-30
Generated in workflow #4801 for commit c7c7268 by the Vitest Coverage Report Action

keller-mark
keller-mark approved these changes Jan 30, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@keller-mark keller-mark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I have tested locally.

@NickAkhmetov NickAkhmetov merged commit b5435ee into main Feb 3, 2026
6 of 7 checks passed
@NickAkhmetov NickAkhmetov deleted the nickakhmetov/vitessce-styles-ts branch February 3, 2026 19:03
@github-actions github-actions bot mentioned this pull request Feb 3, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keller-mark keller-mark keller-mark approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TypeScript conversion for @vitessce/styles

2 participants

@NickAkhmetov @keller-mark