Skip to content

NickAkhmetov/Move informational subtitles below relevant views#2396

Merged
NickAkhmetov merged 2 commits intomainfrom
nickakhmetov/fix-864
Feb 3, 2026
Merged

NickAkhmetov/Move informational subtitles below relevant views#2396
NickAkhmetov merged 2 commits intomainfrom
nickakhmetov/fix-864

Conversation

@NickAkhmetov
Copy link
Copy Markdown
Collaborator

@NickAkhmetov NickAkhmetov commented Jan 28, 2026

Fixes #864

Background

Following up on the discussion in the spatial bio meeting on December 11, this PR proposes the movement of title info text to below the relevant view.

Change List

  • Moves informational subtitles below relevant views.
  • Decreases margin around view to make up for extra space.

Checklist

  • Have tested PR with one or more demo configurations
  • Documentation added, updated, or not applicable
image

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 28, 2026 •
edited
Loading

Size Change: -11.2 MB (-60.31%) 🏆

Total Size: 7.35 MB

Filename Size Change
./packages/main/prod/dist/higlass-DNQIME-h.js 0 B -3.57 MB (removed) 🏆
./packages/main/prod/dist/index-********.js 145 kB -11.2 MB (-98.71%) 🏆
./packages/main/prod/dist/higlass-********.js 3.57 MB +3.57 MB (new file) 🆕
ℹ️ View Unchanged
Filename Size Change
./packages/main/prod/dist/blosc-********.js 612 kB 0 B
./packages/main/prod/dist/chunk-INHXZS53-********.js 558 B 0 B
./packages/main/prod/dist/deflate-********.js 208 B 0 B
./packages/main/prod/dist/index.min.js 1.38 kB 0 B
./packages/main/prod/dist/jpeg-********.js 15.6 kB 0 B
./packages/main/prod/dist/lerc-********.js 89.3 kB 0 B
./packages/main/prod/dist/lz4-********.js 43.9 kB 0 B
./packages/main/prod/dist/lzw-********.js 2.07 kB 0 B
./packages/main/prod/dist/OrbitControls-********.js 229 kB 0 B
./packages/main/prod/dist/packbits-********.js 541 B 0 B
./packages/main/prod/dist/pako.esm-********.js 37.1 kB 0 B
./packages/main/prod/dist/raw-********.js 133 B 0 B
./packages/main/prod/dist/ReactNeuroglancer-********.js 1.67 MB 0 B
./packages/main/prod/dist/troika-three-text.esm-********.js 179 kB 0 B
./packages/main/prod/dist/webimage-********.js 0 B -801 B (removed) 🏆
./packages/main/prod/dist/zstd-********.js 754 kB 0 B
./packages/main/prod/dist/webimage-DsXxj-sd.js 801 B +801 B (new file) 🆕

compressed-size-action

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 28, 2026 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 13.26% 9168 / 69113
🔵 Statements 13.26% 9168 / 69113
🔵 Functions 48.53% 529 / 1090
🔵 Branches 67.32% 1397 / 2075
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/vit-s/src/TitleInfo.js 0% 0% 0% 0% 1-284
packages/vit-s/src/title-styles.js 100% 100% 100% 100%
packages/vit-s/src/shared-mui/container.js 100% 100% 100% 100%
packages/vit-s/src/shared-mui/styles.js 0% 0% 0% 0% 1-138
Generated in workflow #4802 for commit 6f5b3db by the Vitest Coverage Report Action

@NickAkhmetov
Copy link
Copy Markdown
Collaborator Author

NickAkhmetov commented Jan 28, 2026

Test (monorepo) / test-e2e-html (pull_request)

This test failure appears irrelevant to the changes in this PR.

@keller-mark
Copy link
Copy Markdown
Member

keller-mark commented Jan 30, 2026

Yes, please ignore that test-e2e-html higlass test. (I have not figured out what the issue is, and have had trouble reproducing it locally)

@NickAkhmetov NickAkhmetov merged commit 75a1045 into main Feb 3, 2026
6 of 7 checks passed
@NickAkhmetov NickAkhmetov deleted the nickakhmetov/fix-864 branch February 3, 2026 19:03
@github-actions github-actions bot mentioned this pull request Feb 3, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keller-mark keller-mark keller-mark approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move component "subtitles" to bottom of components

2 participants

@NickAkhmetov @keller-mark