feature/Pre-initialize zip stores and pass them in to data loaders#2392
Merged
keller-mark merged 4 commits intomainfrom Jan 27, 2026
Merged
feature/Pre-initialize zip stores and pass them in to data loaders#2392keller-mark merged 4 commits intomainfrom
keller-mark merged 4 commits intomainfrom
Conversation
Contributor
|
Size Change: 0 B Total Size: 7.35 MB
ℹ️ View Unchanged
|
keller-mark
approved these changes
Jan 27, 2026
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2391
Background
This PR updates loader initialization to initialize zip-zarr stores at the top level and merges them into the
storesprop. On config changes, the cache evicts irrelevant stores.I've verified the impact of this change by running the same spatialdata visium config through my local instance and through vitessce.io and using Firefox dev tools to measure total time.
localhost, the conf loaded in ~27 seconds across 5 runsvitessce.io, the conf loaded in ~30 seconds across 5 runsChange List
Checklist
Not opening this for final review yet since I'd like to update the original issue etc to reflect these findings.