Improvements to generateConfig function#2366
Merged
keller-mark merged 4 commits intomainfrom Dec 2, 2025
Merged
Conversation
Contributor
|
Size Change: 0 B Total Size: 7.35 MB ℹ️ View Unchanged
|
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor improvements.
Change List
kindparameter tozarrOpen, which is obtained fromstore.contents()when consolidated metadata is present. Otherwise, zarrita needs to make extra requests as it does not know if we want to open an array or a group. There is still an edge case when arrays lack attrs altogether, and zarrita still makes network requests in these cases as the attrs are not found in the consolidated metadata. I have left a TODO statement about this but it is not currently a major issue as it only results in several extra requests.coerce_dtype. For recarrays the dtype is an array https://github.com/manzt/zarrita.js/blob/23abb3bee9094aabbe60985626caef2802360963/packages/zarrita/src/util.ts#L129Checklist