NickAkhmetov/Increase automatic scatterplot point size for improved visibility#2363
NickAkhmetov/Increase automatic scatterplot point size for improved visibility#2363NickAkhmetov merged 4 commits intomainfrom
Conversation
|
Size Change: 0 B Total Size: 7.35 MB
ℹ️ View Unchanged
|
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
|
This works well for smaller datasets but not larger datasets, such as http://localhost:3000/?dataset=salcher-2022&theme=light2 where the new larger point size makes it difficult to see the patterns (e.g., areas with a mix of yellow and blue cells when zoomed-out) We may want the increased point size to also depend on the size of the dataset (maybe we can use the log of the number of cells?). (The 
|
…on number of cells
…on for separate testing
|
I've adjusted the implementation so that point size scales appropriately between 1,000 cells or less -> 100,000 cells or more; i.e., at 1,000 cells or less, it uses an adjusted 1,000,000 cell example: 4,839 cell example: |
| ) { | ||
| // Calculate point size using reverse logarithmic scaling | ||
| // Smaller datasets get larger point sizes | ||
| const pointSize = getInitialPointSize(numCells); |
There was a problem hiding this comment.
| const pointSize = getInitialPointSize(numCells); | |
| // Allow to range from 0.05 to 0.0005 | |
| const pointSize = 5 / clamp(numCells, 100, 10000); |
Looking more closely, I think we do not need to explicitly take the log10.
There was a problem hiding this comment.
Good call! I've revised the helper function accordingly. I'd still prefer to keep it as a separate function for ease of testing (since the additional re-scaling done by getPointSizeDevicePixels made writing useful tests for this functionality trickier than anticipated)
Fixes #2346
Background
It has been expressed that the default point size on the scatterplot is very small/difficult to work with.
This PR increases the baseline size of the automatically calculated points without affecting the other calculations.
Change List
Checklist
Screenshots
Default
codeluppi-2018scatterplots (in expanded view) on production:Default
codeluppi-2018scatterplots (in expanded view) with this change: