Preserve hidden selected genes in multiselect#2332
Merged
keller-mark merged 6 commits intovitessce:mainfrom Nov 19, 2025
Merged
Preserve hidden selected genes in multiselect#2332keller-mark merged 6 commits intovitessce:mainfrom
keller-mark merged 6 commits intovitessce:mainfrom
Conversation
Member
|
Thank you @marcovarrone ! I made a change to ensure that de-selection while results are filtered works. |
Co-authored-by: Nikolay Akhmetov <nick.akhmetov@gmail.com>
Merged
This was referenced Dec 9, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2331
In
packages/view-types/feature-list/src/FeatureList.js, the gene selection handler now preserves genes that were hidden by a filter: it recomputes newSelection to include any previously selected keys that aren’t present in the current filtered selection before calling setGeneSelection.This ensures that multiselect keeps the filtered-out but selected genes in the shared selection state.
Checklist