This repository was archived by the owner on Jul 24, 2025. It is now read-only.
feat: support HMR for class components#203
Merged
ArnaudBarre merged 1 commit intomainfrom May 20, 2024
Merged
Conversation
640ea48 to
d4730bf
Compare
d4730bf to
de12994
Compare
bluwy
approved these changes
May 9, 2024
Member
bluwy
left a comment
There was a problem hiding this comment.
Trying to understand the changes, does this mean that react-refresh had always supported HMR for class components? And the window.$RefreshReg$ code is only needed if it contains function components with hooks?
Member
Author
|
Yes exactly! |
sapphi-red
approved these changes
May 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #136
Fixes #199
Closes #200
I merged ideas from @n9 in #200 and @marlo22 in fix-react-refresh-plugin
I will port the fix to the Babel plugin once merged to fix oldest issue in the React plugins!