Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a CSS duplication issue in React Server Components by removing duplicate server-side CSS on initial render in development mode. The fix addresses a specific issue where server-generated CSS links were duplicated in the client.
- Adds a virtual plugin that creates a client component to remove duplicate CSS links
- Conditionally includes the CSS removal component only in development mode
- Integrates the removal component into the Resources function for proper execution
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
<link>and client inline<style>#677 (comment)The another PR #681 was removing too early and React ended up injected them on CSR. This PR delays until first
useEffect. This is a similar approach as React router https://github.com/remix-run/react-router/blob/166fd940e7d5df9ed005ca68e12de53b1d88324a/packages/react-router/lib/dom-export/hydrated-router.tsx#L245-L274.TODO