feat!: allow to run Babel on non js/ts extensions (fixes #38)#53
Closed
ArnaudBarre wants to merge 3 commits intomainfrom
Closed
feat!: allow to run Babel on non js/ts extensions (fixes #38)#53ArnaudBarre wants to merge 3 commits intomainfrom
ArnaudBarre wants to merge 3 commits intomainfrom
Conversation
52b0bbb to
549ca18
Compare
Member
|
I think we should wait for this one a bit, given that the release of Vite 4 is so close. Now that the plugin is is in a separate repository we can do a new major for it independent of Vite after the holidays. We can do the a proper beta period and check with the ecosystem. |
sapphi-red
reviewed
Jan 6, 2023
Comment on lines
-214
to
+219
| if (/\.(?:mjs|[tj]sx?)$/.test(extension)) { | ||
| if (filter(id)) { |
Member
There was a problem hiding this comment.
I think this changes behavior when id is foo.txt?a=.jsx. (it was true but now it's false)
4 tasks
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is currently composed of 3 commits:
babel.include/excludeoptions behave vite#6202. Finally I think that changing the behaviour when the import is outside vite root but still imported as source is confusing. I have bad memories of CRA disabling simple code sharing between two projects and requiring to setup a fake local lib.Fixes #38, fixes #22, fixes #24 and should also fix #16