feat: add optional ttlDays parameter#98
Merged
bluwy merged 6 commits intovitejs:mainfrom Mar 24, 2026
Merged
Conversation
bluwy
reviewed
Mar 11, 2026
bluwy
approved these changes
Mar 16, 2026
Member
bluwy
left a comment
There was a problem hiding this comment.
I'd like another maintainer to double check this before merging. For me it's working locally though.
Contributor
Author
|
@bluwy Any update? Can we get someone else to take a look? |
sapphi-red
approved these changes
Mar 24, 2026
ttlDays parameter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #97
Adds a new optional parameter to allow the expiration date of the certificate to be customized past the default 30 days.
Happy to rename the parameter if there's a better name that we could use.