I think we should also merge this one in Vite 3.1. We could start issuing a warning in Vite 4 when enforce is used, and then remove it next year in Vite 5. It would be nice to do it in v4, but it is a significant breaking change for a small maintenance cost.

As we now have hook level order, do we still need plugin level order/enforce?
IIUC plugin level order/enforce is just a shorthand of setting every hook's order. Is it common that the hook's order to be the same? (Now it is because we didn't have hook level order and it was the only way)
I feel aligning to rollup (removing the plugin level enforce completely) is better for the ecosystem.

I agree that we should deprecate enforce first and remove enforce in Vite 5.

I think the order of the plugin still matters.

• A nitch case I'd say a post plugin's post hook is not equivalent to a pre plugin's post hooks.
• It would be verbose if you want every hook to have the order.

It would be great if Rollup would like to introduce top-level order, but even if not, I still think it would be valuable for Vite given our application is more complex.

Ah, so there is 3 * 3 = 9 orders now. Am I correct?

1. plugin level pre + hook level pre
2. plugin level normal + hook level pre
3. plugin level post + hook level pre
4. plugin level pre + hook level null
5. plugin level normal + hook level null
6. plugin level post + hook level null
7. plugin level pre + hook level post
8. plugin level normal + hook level post
9. plugin level post + hook level post

Ah, so there is 3 * 3 = 9 orders now. Am I correct?

Yes, and the order you listed would be respected for Vite.

It would be verbose if you want every hook to have the order.

I think we should keep order at the plugin level because of this reason.

A nitch case I'd say a post plugin's post hook is not equivalent to a pre plugin's post hooks.

This feels a bit too niche to me. Still on the fence about what is better:

1. order is only a plugin-level default for all hooks
2. order both move the plugin and is a default for the hooks

I feel 1. is more consistent. If we want to attack that niche case, maybe is it better to rely on normal ordering, or to add more stages in the future? ('start', 'pre', 'normal', 'post', 'end'). The reason I like 2 is that I'm very used to see the plugin when we log things jump to the enforced position, but I expect this to change once we get used to 'order' at the hook level not doing this.

After the team meeting, we think it's better to hold this PR. Having it named enforce makes it clear it's a Vite-specific behavior and not confusing with Rollup's order. Also, avoiding collision in case Rollup might introduce the top-level order in the future.

Having it named enforce makes it clear it's a Vite-specific behavior and not confusing with Rollup's order. Also, avoiding collision in case Rollup might introduce the top-level order in the future.

Does that mean this PR should be closed?

There's a merge conflict that would need to be resolved if this is still going to be pursued

Yes, I think we shall close for now.