fix: ignore tsconfig target when bundling config#9457
Merged
bluwy merged 1 commit intovitejs:mainfrom Aug 1, 2022
Merged
Conversation
bluwy
reviewed
Jul 31, 2022
bluwy
approved these changes
Jul 31, 2022
|
@sapphi-red @bluwy This seems to be broken again, works when I downgrade to https://stackblitz.com/edit/vitejs-vite-h1gxde?file=package.json&terminal=dev doesn't work with |
Member
|
@htmnk would you create a new issue with a reproduction against latest so we can properly track the regression? Thanks! |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When
target: es5is set intsconfig.jsonandvite.config.tsexists, Vite fails to start.This is because esbuild looks for that when bundling config.
Because we always ignore
targetintsconfig.jsonand users won't expecttargetfield to be respected for config loading, I think it is better to ignoretargetfield here too.reproduction: https://stackblitz.com/edit/vitejs-vite-h1gxde?file=vite.config.ts&terminal=dev
Additional context
related discussion: #3827
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).