fix: update tsconfig.json error #9409#9412
Closed
caoxiemeihao wants to merge 1 commit intovitejs:mainfrom
Closed
Conversation
This was referenced Jul 28, 2022
d582a46 to
87858e2
Compare
Member
|
This change make sense to me, and it's better in the long run to avoid the singleton. It looks like the tests are failing though. |
Contributor
Author
|
Fixed by #11747 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Error while tsconfig.json hot update #9409
fix #9409
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).