feat: support import assertions#8937
Merged
patak-cat merged 1 commit intovitejs:mainfrom Jul 5, 2022
bluwy:feat-support-import-assertions
Merged
feat: support import assertions#8937patak-cat merged 1 commit intovitejs:mainfrom bluwy:feat-support-import-assertions
patak-cat merged 1 commit intovitejs:mainfrom
bluwy:feat-support-import-assertions
Conversation
✅ Deploy Preview for vite-docs-main ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
patak-cat
approved these changes
Jul 5, 2022
Member
patak-cat
left a comment
There was a problem hiding this comment.
Sweet! I agree that this is a good step forward. We may want later to document this, and once the support is more extended re-evaluate what is the best to avoid stripping them.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #4934
This basically strips off the import assertion part as Vite already handles it.
It's still a stage 3 feature, but esbuild, rollup, and other tools all already support it. Using import assertions in deps works today.
Additional context
I see some downsides if we don't strip it, and instead let browsers handle natively:
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).