✅ Deploy Preview for vite-docs-main ready!

Name	Link
🔨 Latest commit	d63cdb3
🔍 Latest deploy log	https://app.netlify.com/sites/vite-docs-main/deploys/62b494e7572cff0008f2a499
😎 Deploy Preview	https://deploy-preview-8746--vite-docs-main.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Would you explain why we would like to avoid the printing of the new URLs when calling restart(), but still have them in the HMR logic?

User may use Javascript API, createServer doesn't print the url automatically, so i think it shouldn't print when restarting either.

import { createServer } from "vite";
import { SHOULD_PRINT_URL } from "./consts";

const server = await createServer({ base: "/a/", configFile: false });
SHOULD_PRINT_URL && server.printUrls();

async function restartServer() {
  await server.restart();
  SHOULD_PRINT_URL && server.printUrls();
}

// ...
server.config.inlineConfig.base = "/b/";
restartServer();

The printing code was added without considering that the restart function would be exposed, but for now I think that code should be left to the caller.These prints are still necessary for Vite CLI-powered applications, so i left them in HMR logic. :)

This makes sense to me partially.

But when metaframeworks that uses createServer and uses their own function similar to server.printUrls, they still cannot change the output when the config is changed.

We might need to think about #6997 (comment) and #8986 together with this PR.

@CHOYSEN would you rebase this PR? Let's try to merge it for Vite 5, or otherwise decide if we prefer to keep things as is.

sure

/ecosystem-ci run

📝 Ran ecosystem CI on 00528b4: Open

The more I think about it, the more I'm unsure this is the right fix. This PR moves the printUrls away, but that still can be called in HMR. Personally I think the best way is this: "if printUrls was never called, then we also don't print it whenever we restart the server" 🤔

Added the printing for shortcuts, but I'm still not sure if this is the right solution.

Oh, there is a conflict, I think you can merge it once it is resolved then.