Skip to content

fix: remove ssrError when invalidating a module#8124

Merged
patak-cat merged 1 commit intovitejs:mainfrom
withastro:invalidate-ssr-error3
May 11, 2022
Merged

fix: remove ssrError when invalidating a module#8124
patak-cat merged 1 commit intovitejs:mainfrom
withastro:invalidate-ssr-error3

Conversation

@matthewp
Copy link
Copy Markdown
Contributor

Description

This removes ssrError when invalidating a module from the graph (which happens when a module is changed).

Additional context

This is a follow up to #8052 which partially fixed the problem.

This fixes a bug in Astro: withastro/astro#3263


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy changed the title fix: Remove ssrError when invalidating a module fix: remove ssrError when invalidating a module May 11, 2022
@bluwy bluwy added p3-minor-bug An edge case that only affects very specific usage (priority) feat: ssr labels May 11, 2022
@patak-cat patak-cat merged commit a543220 into vitejs:main May 11, 2022
@matthewp matthewp deleted the invalidate-ssr-error3 branch May 11, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat: ssr p3-minor-bug An edge case that only affects very specific usage (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants