fix: remove ssrError when invalidating a module#8124
Merged
patak-cat merged 1 commit intovitejs:mainfrom May 11, 2022
Merged
Conversation
9 tasks
bluwy
approved these changes
May 11, 2022
patak-cat
approved these changes
May 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This removes
ssrErrorwhen invalidating a module from the graph (which happens when a module is changed).Additional context
This is a follow up to #8052 which partially fixed the problem.
This fixes a bug in Astro: withastro/astro#3263
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).