Skip to content

fix: use Vitest for unit testing, clean regex bug#8040

Merged
patak-cat merged 6 commits intomainfrom
chore/vitest-unit-tests
May 6, 2022
Merged

fix: use Vitest for unit testing, clean regex bug#8040
patak-cat merged 6 commits intomainfrom
chore/vitest-unit-tests

Conversation

@antfu
Copy link
Member

@antfu antfu commented May 6, 2022 •
edited
Loading

Description

Currently, we are mixing the integration tests and unit tests. With the goal that we might use Vitest exclusively in the future, this PR takes the progressive approach by letting Vitest handles the unit tests first, providing a better DX over each feature.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@antfu
Copy link
Member Author

antfu commented May 6, 2022

Interestingly this exposes a bug of Vite itself.

vite/packages/vite/src/node/plugins/workerImportMetaUrl.ts

Line 115 in 474d5c2

/\bnew\s+(Worker|SharedWorker)\s*\(\s*(new\s+URL\s*\(\s*('[^']+'|"[^"]+"|`[^`]+`)\s*,\s*import\.meta\.url\s*\))/g

This regex breaks our logic of lexing strings

vite/packages/vite/src/node/cleanString.ts

Line 26 in e48827f

;[clean, lastEnd] = lexStringTemplateExpression(res, start)

@bluwy
Copy link
Member

bluwy commented May 6, 2022

Your bug fix may indirectly resolve #8014 too

patak-cat
patak-cat reviewed May 6, 2022
View reviewed changes
@patak-cat patak-cat changed the title chore: use Vitest for unit testing fix: use Vitest for unit testing, clean regex bug May 6, 2022
@patak-cat patak-cat merged commit 63cd53d into main May 6, 2022
@patak-cat patak-cat deleted the chore/vitest-unit-tests branch May 6, 2022 08:00
@jeffydc jeffydc mentioned this pull request May 6, 2022
Closed
@benmccann benmccann mentioned this pull request May 7, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patak-cat patak-cat patak-cat approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@antfu @bluwy @patak-cat