Skip to content

fix(ssr): allow ssrTransform to parse hashbang#8005

Merged
patak-cat merged 3 commits intovitejs:mainfrom
togami2864:feat/allow-shebang
May 4, 2022
Merged

fix(ssr): allow ssrTransform to parse hashbang#8005
patak-cat merged 3 commits intovitejs:mainfrom
togami2864:feat/allow-shebang

Conversation

@togami2864
Copy link
Copy Markdown
Contributor

Description

fix #8002

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link
Copy Markdown
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, my bad. Looks like the tests are failing. I think it's related to the snapshots whitespace updates in the diff. Source changes looks good though.

@bluwy bluwy added p2-nice-to-have Not breaking anything but nice to have (priority) feat: ssr labels May 3, 2022
@patak-cat patak-cat merged commit 6420ba0 into vitejs:main May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat: ssr p2-nice-to-have Not breaking anything but nice to have (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable to parse shebang in the function ssrTransform

4 participants