fix: warn for unresolved css in html#7911
Merged
patak-cat merged 7 commits intovitejs:mainfrom May 4, 2022
Merged
Conversation
patak-cat
reviewed
Apr 26, 2022
patak-cat
reviewed
Apr 26, 2022
patak-cat
reviewed
Apr 26, 2022
Comment on lines
+342
to
+346
| styleUrls.push({ | ||
| url, | ||
| start: node.loc.start.offset, | ||
| end: node.loc.end.offset | ||
| }) |
Member
There was a problem hiding this comment.
I'm still unsure about the order change in the JS that this is going to produce. IIUC, before if the user had first the CSS styles, these were the first imports in the JS, and now they will be imported at the end after all other JS tags. I wonder if we should mark the JS position by adding something like
js += `${STYLE_IMPORT_MARKER_}${styleUrlId}`
And then we can replace it by \nimport ... or by `` depending on the result of the URL resolution.
Co-authored-by: patak <matias.capeletto@gmail.com>
patak-cat
approved these changes
May 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix: #7160
Additional context
catch unresolved css url in html.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).