fix: EACCES permission denied due to resolve new paths default#7612
Merged
patak-cat merged 1 commit intovitejs:mainfrom Apr 5, 2022
Merged
fix: EACCES permission denied due to resolve new paths default#7612patak-cat merged 1 commit intovitejs:mainfrom
patak-cat merged 1 commit intovitejs:mainfrom
Conversation
Compatible with changes made by the new version of upstream component "resolve".
patak-cat
approved these changes
Apr 4, 2022
Member
patak-cat
left a comment
There was a problem hiding this comment.
TIL browserify/resolve#163 (comment)
This LGTM, I think given how many people have reported issues (see activity in #6767) with the new default of paths looking into .node_modules, it is safer to get back to the previous behavior.
At least we should change it when we get a real issue that justifies it. We may also want to backport this fix to 2.7 and 2.8, after testing it for a while in 2.9.
7 tasks
|
When will the new release be that includes this PR? This is a blocking issue for me as I can't deploy my Vite app to |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Compatible with changes made by the new version of upstream component "resolve".
Fix #6767.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).