feat: handle dynamic imports in dependencies#7564
Closed
bluwy wants to merge 1 commit intovitejs:mainfrom
bluwy:dynamic-import-dep
Closed
feat: handle dynamic imports in dependencies#7564bluwy wants to merge 1 commit intovitejs:mainfrom bluwy:dynamic-import-dep
bluwy wants to merge 1 commit intovitejs:mainfrom
bluwy:dynamic-import-dep
Conversation
Member
Author
|
Putting this as draft to look into #6179 (comment) |
Member
Author
|
Closing as I haven't got time to investigate #6179 (comment). Looking back now, the preloads may not be an easy thing to do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Handle dynamic imports in dependencies.
Closes #6179
Additional context
I traced back the original commit to 7cbbca4#diff-ccfa1619b540f121f06e0d19a93c42f51481f573802dfd1cff67f2d0b3a42f32
It looks like that's the default behaviour all along, but it's not clear to me why so.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).