Conversation
bluwy
approved these changes
Mar 30, 2022
This was referenced Apr 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
@Artur- reported that the changes in #7463 produced an infinite loop in their app (a Java-Vite integration). @Artur-, maybe later you could provide more details about your setup to @lukashass so a new PR could be tried taking into account your use case
@lukashass found that
hmr.port: falsewas not working as expected, and we may not need this option if a new take on #7643 is implemented. Reverting for the moment to avoid adding a new option in 2.9 if it isn't going to be neededWhat is the purpose of this pull request?