Skip to content

feat: beautify the source maps#7505

Closed
smallp wants to merge 1 commit intovitejs:mainfrom
smallp:main
Closed

feat: beautify the source maps#7505
smallp wants to merge 1 commit intovitejs:mainfrom
smallp:main

Conversation

@smallp
Copy link

@smallp smallp commented Mar 29, 2022 •
edited
Loading

Description

Move source maps to source-maps://.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p2-nice-to-have Not breaking anything but nice to have (priority) label Mar 29, 2022
@sapphi-red
Copy link
Member

sapphi-red commented May 18, 2022

Could you add the same logic here for css sourcemaps?

vite/packages/vite/src/node/plugins/css.ts

Lines 353 to 355 in c86329b

const sourcemap = this.getCombinedSourcemap()
await injectSourcesContent(sourcemap, cleanUrl(id), config.logger)
return getCodeWithSourcemap('css', content, sourcemap)

@smallp
Copy link
Author

smallp commented May 19, 2022

@sapphi-red
I don't believe we need to do that.
All requests would call transformRequest where I add namespace here. So we don't have to add it again.

@sapphi-red
Copy link
Member

sapphi-red commented May 19, 2022

transformRequest won't be called for css dev sourcemaps because the source maps for them are inlined.

@smallp
Copy link
Author

smallp commented May 19, 2022

Got it. Done.

@sapphi-red sapphi-red linked an issue May 19, 2022 that may be closed by this pull request
Separate Source Maps' files from real files via namespace #2950
Closed
@smallp smallp closed this Sep 19, 2022
@smallp smallp reopened this Sep 19, 2022
@smallp
Copy link
Author

smallp commented Sep 19, 2022

@sapphi-red Rebased. And who can review it? It is months.

@sapphi-red
Copy link
Member

sapphi-red commented Nov 12, 2025

Closing for this reason (#2950 (comment)).

@sapphi-red sapphi-red closed this Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

p2-nice-to-have Not breaking anything but nice to have (priority)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Separate Source Maps' files from real files via namespace

4 participants

@smallp @sapphi-red @patak-cat @bluwy