fix: avoid mangling code from incorrect magic-string usage#7397
Merged
Conversation
bluwy
approved these changes
Mar 21, 2022
bluwy
left a comment
Member
There was a problem hiding this comment.
LGTM. I don't think there are places where we'd expect the contentOnly: false behaviour. And the tests passed too.
patak-cat
approved these changes
Mar 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7365
The current default in
magic-stringseems like a bit of a footgun. Until / unless the default is changed (Rich-Harris/magic-string#211), we should manually specifycontentOnly: trueAdditional context
This is causing difficult to diagnose errors in SvelteKit with SvelteKit itself giving errors like "Method not allowed" due to incorrectly compiled
.jsfilesWhat is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).