fix: add version to optimized chunks, fix #7323#7350
Merged
Conversation
This was referenced Mar 16, 2022
bluwy
approved these changes
Mar 16, 2022
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #7323
Revert an attempt to make an optimization made by #6758: Chunks already have a hash in the file name
chunk-{hash}.js, so the idea was that adding the?v={browserHash}wasn’t needed.It was a wrong assumption, after a deps pre-bundling rerun some of the chunks could remain unchanged so the extra
?v=hash is required.What is the purpose of this pull request?